Repository navigation
chore(dev): binary-report.sh for ELF size and relocation reports - #1479
duncanista wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06470fe9a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
duncanista
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 880b92fe7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…te diffs deterministically
TL;DR: A script that reports ELF section sizes, relocations, linked libraries and size per crate, and compares two binaries.
Why: Binary size and relocations drive the page-ins from the compressed
/optat cold start. When the size changes, this shows which crate it comes from.Overview
Jira: SVLS-9976
Stacked on #1478 (
jordan.gonzalez/dev-patch-deps/feature).scripts/dev/binary-report.sh(wrapper ofbinary_report.py) prints a JSON report for aLinux ELF binary without
readelforcargo bloat, so it also runs on macOS:.rela.dyn,.relr.dyn),NEEDEDlibraries,
BIND_NOWandPIEflags;.textsize from the symbol table;--diff oldadds the deltas.The GitLab binary report job later in this stack uses it.
Size: 269 core lines, 288 lines in total.
Testing
python3 -m py_compile: pass